It an add other outputs for other reasons too, not just change.

Also that line should have "PaymentDetails" changed to "PaymentRequest". We took out PaymentDetails.

I see... In that case how about something like:

Creates and signs a transaction that satisfy (pay in full) PaymentRequest.outputs. It may add additional outputs if needed.

That makes sense. Again, "PaymentDetails" should be "PaymentRequest".

yes - comment fixed

Merged. Another relevant comment, though: It's actually unclear what the order of the outputs should be. Inside MB, we sort the outputs for increased privacy. This means the outputs are NOT returned in the same order. Perhaps we should clarify whether they should or should not be in the same order.

Clarification would be good.
I believe that the better choice would be to not enforce any order.

It is technically possible to satisfy 2 payment requests with 1 transaction (and send that transaction to 2 different servers). Both are gonna find their inputs in it, but it is not possible for both to get the ordering they expected.

// though... I have no idea why anyone would do something like that. :D

deleting this branch.

on output ordering, i created a new PR: #11